Skip to content

Conversation

benank
Copy link
Contributor

@benank benank commented Mar 18, 2022

Fixes all AssertEquals deprecations warnings from the tests by replacing them with AssertEqual. Tests work fine on both Python 2.7 and 3.9.

@benank benank requested review from a team, kjohn-msft and rane-rajasi and removed request for a team March 18, 2022 20:17
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #128 (5b90ff3) into master (53f6ca6) will increase coverage by 6.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   80.77%   86.95%   +6.17%     
==========================================
  Files          86       48      -38     
  Lines       11682     8230    -3452     
==========================================
- Hits         9436     7156    -2280     
+ Misses       2246     1074    -1172     
Flag Coverage Δ
python27 85.76% <100.00%> (+5.89%) ⬆️
python39 86.90% <100.00%> (+6.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/tests/Test_AptitudePackageManager.py 99.12% <100.00%> (ø)
src/core/tests/Test_ConfigurePatchingProcessor.py 98.85% <100.00%> (ø)
src/core/tests/Test_CoreMain.py 99.84% <100.00%> (ø)
src/core/tests/Test_LifecycleManagerArc.py 94.59% <100.00%> (ø)
src/core/tests/Test_LifecycleManagerAzure.py 94.79% <100.00%> (ø)
src/core/tests/Test_TelemetryWriter.py 95.62% <100.00%> (ø)
src/core/tests/Test_YumPackageManager.py 99.03% <100.00%> (ø)
src/core/tests/Test_ZypperPackageManager.py 96.35% <100.00%> (ø)
src/extension/tests/Test_ActionHandler.py
src/extension/tests/Test_ProcessHandler.py
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7110c15...5b90ff3. Read the comment docs.

@benank benank merged commit 3e34573 into master Mar 21, 2022
@benank benank deleted the bankiel-deprecationfix branch March 21, 2022 18:49
@benank benank mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants