Fix failing GitHub workflow tests #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 87.42% 87.43% +0.01%
==========================================
Files 48 48
Lines 8326 8335 +9
==========================================
+ Hits 7279 7288 +9
Misses 1047 1047
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
benank
changed the title
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
|
Closing for now since tests no longer appear to be flaky. Re-open if issue persists. |
|
Reopening as this is still an issue. However, the current changes in this PR will likely not fix it. Needs more investigation. |
|
Closing as this is not occurring often. |
|
Reopening as this is happening much more frequently now. |
added 22 commits
August 16, 2022 16:57
benank
changed the title
kjohn-msft
reviewed
Aug 22, 2022
kjohn-msft
reviewed
Aug 22, 2022
kjohn-msft
reviewed
Aug 22, 2022
kjohn-msft
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled 4 tests that were failing 100% of the time on GitHub runners. Fixed temporary directory creation to use the runner's temporary directory. Also updated the workflow with newer versions for actions and split up large operations into multiple steps.