Write to multiple statuses for ConfigurePatching on error #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 87.05% 87.09% +0.04%
==========================================
Files 48 48
Lines 8263 8274 +11
==========================================
+ Hits 7193 7206 +13
+ Misses 1070 1068 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
benank
commented
Apr 14, 2022
| return | ||
| if not self.telemetry_writer.is_agent_compatible(): | ||
| error_msg = "{0} [{1}]".format(Constants.TELEMETRY_AT_AGENT_NOT_COMPATIBLE_ERROR_MSG, self.telemetry_writer.get_telemetry_diagnostics()) | ||
| self.composite_logger.log_error(error_msg) |
There was a problem hiding this comment.
Line removed because __report_consolidated_configure_patch_status logs the error, so this results in duplicate messages (at least, without the duplicate checking code that exists).
kjohn-msft
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ConfigurePatching fails with an error, the error is now also written to
autoAssessmentStateanderrorssections inautoAssessmentStatus.