Differentiate logs from auto assessment and auto patching #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 87.22% 87.24% +0.01%
==========================================
Files 48 48
Lines 8354 8366 +12
==========================================
+ Hits 7287 7299 +12
Misses 1067 1067
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
rane-rajasi
reviewed
Jun 14, 2022
src/core/src/bootstrap/Constants.py
Outdated
| # To separately preserve assessment + auto-assessment state information | ||
| ASSESSMENT_STATE_FILE = "AssessmentState.json" | ||
| AUTO_ASSESSMENT_MAXIMUM_DURATION = "PT1H" | ||
| MIN_AUTO_ASSESSMENT_INTERVAL = "PT6H" # do not perform auto-assessment if the last assessment happened less than this time interval ago |
There was a problem hiding this comment.
Are these used in the code anywhere?
There was a problem hiding this comment.
Not yet. Will be used in a future PR. Removed for now.
rane-rajasi
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any markers to differentiate between the extension telemetry events coming from an auto assessment operation and any of the non auto assessment operations. With auto assessment running in regular intervals, we should consider adding some marker to differentiate between these logs for easier investigation. This PR adds some markers to differentiate between logs.