Fix telemetry not working #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 48 48
Lines 8324 8324
=======================================
Hits 7266 7266
Misses 1058 1058
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
rane-rajasi
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #140
The previous PR set whether or not telemetry was supported or not too early in the execution. It should be set in
setup_telemetrysince that is where the events folder for telemetry is also set, which the check uses.Also includes extra exit code.