Add AssessmentState file and max auto assessment interval #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2022 16:03
benank
changed the title
added 2 commits
June 22, 2022 10:22
benank
changed the title
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 88.01% 88.15% +0.14%
==========================================
Files 86 86
Lines 12084 12227 +143
==========================================
+ Hits 10636 10779 +143
Misses 1448 1448
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rane-rajasi
reviewed
Jul 27, 2022
rane-rajasi
reviewed
Jul 28, 2022
rane-rajasi
reviewed
Jul 28, 2022
rane-rajasi
reviewed
Jul 28, 2022
| assessment_state = self.runtime.patch_assessor.read_assessment_state() | ||
| with open(self.runtime.patch_assessor.assessment_state_file_path, 'r') as file_handle: | ||
| assessment_state_from_file = json.loads(file_handle.read())["assessmentState"] | ||
| self.assessment_state_equals(assessment_state, assessment_state_from_file) |
There was a problem hiding this comment.
Another way to validate write_assessment_state(), updated an existing AssessmentState.json will be to compare the lastHeartbeat before and after write_assessment_state(), i.e:
- Read AssessmentState before line 79 i.e. before write_assessment_state()
- Call write_assessment_state()
- Read the file
- compare lastHeartbeat between step 1 and 3, should not be the same
There was a problem hiding this comment.
Ben is aware of what to do here. Ack
rane-rajasi
reviewed
Jul 28, 2022
rane-rajasi
reviewed
Jul 28, 2022
kjohn-msft
reviewed
Aug 24, 2022
kjohn-msft
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an AssessmentState.json file with details about when the last assessment ran. Also includes a 6 hour minimum delay between auto assessment runs.