Bugfix for error while updating top level message field in status file #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rane-rajasi
requested review from
a team,
benank and
kjohn-msft
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 48 48
Lines 8324 8324
=======================================
Hits 7266 7266
Misses 1058 1058
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
benank
reviewed
Jun 24, 2022
| self.update_key_value_safely(status_json[0], self.file_keys.status_status, status, self.file_keys.status_status) | ||
| self.update_key_value_safely(status_json[0], self.file_keys.status_code, code, self.file_keys.status_status) | ||
| self.update_key_value_safely(status_json[0], self.file_keys.timestamp_utc, str(datetime.datetime.utcnow().strftime(Constants.UTC_DATETIME_FORMAT))) | ||
| self.update_key_value_safely(status_json[0][self.file_keys.status_status], self.file_keys.status_formatted_message_message, str(message), self.file_keys.status_formatted_message) |
There was a problem hiding this comment.
Why is the status_status key used here?
mirichmo
requested changes
Jun 24, 2022
| self.update_key_value_safely(status_json[0], self.file_keys.status_status, status, self.file_keys.status_status) | ||
| self.update_key_value_safely(status_json[0], self.file_keys.status_code, code, self.file_keys.status_status) | ||
| self.update_key_value_safely(status_json[0], self.file_keys.timestamp_utc, str(datetime.datetime.utcnow().strftime(Constants.UTC_DATETIME_FORMAT))) | ||
| self.update_key_value_safely(status_json[0][self.file_keys.status_status], self.file_keys.status_formatted_message_message, str(message), self.file_keys.status_formatted_message) |
There was a problem hiding this comment.
should there be a comma between status_json[0] and self.file_keys?
There was a problem hiding this comment.
No because it's to access the key inside status_json[0]
benank
approved these changes
Jun 25, 2022
mirichmo
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code was failing to write top level message in status file with the error reported as
This was not a blocker or terminal error but affected our reporting status accurately in status blob