Fix telemetry writer extension tests #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 48 48
Lines 8326 8326
=======================================
Hits 7279 7279
Misses 1047 1047
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kjohn-msft
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4/6 telemetry writer tests in the extension are currently failing 100% of the time. However, they only fail when run individually or only as a file (right click Test_TelemetryWriter -> Run Unittests...). If the tests are run as part of all the extension tests, they succeed.
Previously, the GitHub runner did not encounter issues with these tests. Within the last month, this issue has started to occur on GitHub and can also be reproduced locally.
The issue is that the telemetry writer tests do not use RuntimeComposer, which mocks the call to
os.getenv, which is necessary for telemetry initialization through environment variables. This PR fixes the problem by adding RuntimeComposer to the telemetry writer tests.