Log changes #166
Log changes #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 88.16% 88.51% +0.35%
==========================================
Files 86 86
Lines 12230 12595 +365
==========================================
+ Hits 10782 11149 +367
+ Misses 1448 1446 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| if raise_if_delete_failed: | ||
| raise Exception(error_message) | ||
| else: | ||
| print(error_message) |
There was a problem hiding this comment.
We don't have a logger reference in EnvLayer so print is the way to log if needed
| return process if did_process_start else None | ||
|
|
||
| # Clear temp folder since core process launch failed | ||
| ext_env_handler.delete_temp_folder_contents() |
There was a problem hiding this comment.
is this needed? Enable action has already cleanup the content before we get there
There was a problem hiding this comment.
Not needed right now since we only have one use of the tmp folder (i.e. save only one file type from core).
But tmp folder can have more use cases in future. In that case, this could be a fail safe method to ensure handler cleans everything if a core launch fails (if things are introduced to the tmp folder while launching core)
No description provided.