Apt debstyle882 support, bug-fixes in cache evaluation & manipulation #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 92.03% 92.09% +0.05%
==========================================
Files 90 91 +1
Lines 15760 15953 +193
==========================================
+ Hits 14505 14692 +187
- Misses 1255 1261 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kjohn-msft
changed the title
feng-j678
previously approved these changes
Nov 11, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
approved these changes
Nov 19, 2024
feng-j678
approved these changes
Nov 19, 2024
Merged
kjohn-msft
added a commit
that referenced
this pull request
Apr 20, 2025
**Background:** For VMs that are Ubuntu Pro client capable, there are 2 sets of issues that manifest as required security updates not getting installed on machines_ (some machines). 1. Canonical is aware of packages normally seen as updates in the default flow not being shown as required in pro client scans. There is an explanation for this but the way we have taken a tight dependency on pro client when it's functional causes these updates no to get installed. 2. There are cases where wide swathes of security updates are not getting detected by pro client. It was not clear if this was a pro client issue in the past or an issue with our code. The additional code that went in November helped identify that this was a pro client issue when newer reports came in: #273 Both problems listed above are being resolved by not fully relying on pro client and using a combined overlay of the default scanning mechanism with whatever pro client reports. This is the 'best of both worlds' approach. Extensive logging additions will help further reviews with Canonical on pro client behaviors without affecting any customer while a multi-stage resolution is ironed out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Stable code is deprioritized.
- Log origination is made clear with tagging & without having to look at code.
- IDE hinting on types are introduced.
- Customer environment errors are called out explicitly as such.