address the stringio getvalue not found error in ut #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-j678
requested review from
kjohn-msft,
rane-rajasi and
najams
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 91.10% 91.11%
=======================================
Files 91 91
Lines 15893 15901 +8
=======================================
+ Hits 14480 14488 +8
Misses 1413 1413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kjohn-msft
approved these changes
Oct 24, 2024
rane-rajasi
approved these changes
Oct 25, 2024
feng-j678
force-pushed
the
fix/ut_os_getvalue
branch
from
8bf1403 to
4687d10
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] do a try catch import on StringIO fix 'file' object has no attribute 'getvalue' in py2
