-
Notifications
You must be signed in to change notification settings - Fork 11
Fix/distutil deprecation #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pull origin master changes
…into fix/py312_triplequotes pull master changes conflicts.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
+ Coverage 92.22% 92.26% +0.03%
==========================================
Files 92 96 +4
Lines 16017 16105 +88
==========================================
+ Hits 14772 14859 +87
- Misses 1245 1246 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor the duplicate code. rest looks fine.
…into fix/distutil_deprecation pull master changes .
c73dd2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment inline
…into fix/distutil_deprecation
…inuxPatchExtension into fix/distutil_deprecation pull master changes
[heart] Nikhil Mengaram reacted to your message:
…________________________________
From: feng-j678 ***@***.***>
Sent: Friday, December 20, 2024 6:00:20 PM
To: Azure/LinuxPatchExtension ***@***.***>
Cc: Nikhil Mengaram ***@***.***>; Comment ***@***.***>
Subject: Re: [Azure/LinuxPatchExtension] Fix/distutil deprecation (PR #280)
Merged #280<#280> into master.
—
Reply to this email directly, view it on GitHub<#280 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASLRMKJ2JEIZAFU5ZPYX6QT2GRLLJAVCNFSM6AAAAABSNLFEVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG4ZTKNBUHE2DGMA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
[x] addressed distutil module deprecation in py312, deprecation is causing failure in vms with py312. to address this, created a customize comparator class to compare extension version numbers, extract the version numbers from the config path, and sort all existing extension versions to get the latest version. this comparator class is also being used to check ubuntu pro client machine versions.


[x] add ut for comparator class in core and extension
[x] core ut result:
[x] extension ut result:
