Skip to content

Conversation

feng-j678
Copy link
Contributor

@feng-j678 feng-j678 commented Nov 25, 2024

[x] addressed distutil module deprecation in py312, deprecation is causing failure in vms with py312. to address this, created a customize comparator class to compare extension version numbers, extract the version numbers from the config path, and sort all existing extension versions to get the latest version. this comparator class is also being used to check ubuntu pro client machine versions.
image
[x] add ut for comparator class in core and extension
[x] core ut result:
image

[x] extension ut result:
image

image

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 98.96907% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (1061282) to head (2d6affd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/tests/Test_VersionComparator.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   92.22%   92.26%   +0.03%     
==========================================
  Files          92       96       +4     
  Lines       16017    16105      +88     
==========================================
+ Hits        14772    14859      +87     
- Misses       1245     1246       +1     
Flag Coverage Δ
python27 92.26% <98.96%> (+0.03%) ⬆️
python39 92.26% <98.96%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feng-j678 feng-j678 marked this pull request as ready for review November 25, 2024 17:48
Copy link
Member

@SathishMSFT SathishMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the duplicate code. rest looks fine.

SathishMSFT
SathishMSFT previously approved these changes Dec 11, 2024
nikhim-um
nikhim-um previously approved these changes Dec 12, 2024
@feng-j678 feng-j678 dismissed stale reviews from nikhim-um and SathishMSFT via c73dd2a December 12, 2024 21:32
nikhim-um
nikhim-um previously approved these changes Dec 13, 2024
Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inline

@feng-j678 feng-j678 merged commit 6cf2812 into master Dec 20, 2024
7 checks passed
@feng-j678 feng-j678 deleted the fix/distutil_deprecation branch December 20, 2024 18:00
@nikhim-um
Copy link
Contributor

nikhim-um commented Dec 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants