Skip to content

Conversation

kjohn-msft
Copy link
Collaborator

This PR makes no functional changes to the code beyond:

  • more clarity in logging origin through tagging with source file acronyms.
  • deprioritizing some logs (debug to verbose) that are in years-old highly stable code paths.

This is similar to code that's already gone in for Apt.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 82.82828% with 34 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (772ba51) to head (4d45494).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/src/package_managers/YumPackageManager.py 84.00% 16 Missing ⚠️
.../core/src/package_managers/ZypperPackageManager.py 83.13% 14 Missing ⚠️
src/core/src/package_managers/PackageManager.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files          92       92              
  Lines       16035    16017      -18     
==========================================
- Hits        14790    14772      -18     
  Misses       1245     1245              
Flag Coverage Δ
python27 92.22% <82.82%> (-0.01%) ⬇️
python39 92.22% <82.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kjohn-msft kjohn-msft merged commit 28a7647 into master Nov 28, 2024
4 of 6 checks passed
@kjohn-msft kjohn-msft deleted the kjohn-yumzypmatchapt branch November 28, 2024 00:43
@kjohn-msft kjohn-msft mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants