-
Notifications
You must be signed in to change notification settings - Fork 11
Apt - fix for non-sec updates getting misclassified & related tmp cleanup #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 92.42% 92.43% +0.01%
==========================================
Files 97 97
Lines 16199 16226 +27
==========================================
+ Hits 14972 14999 +27
Misses 1227 1227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feng-j678
previously approved these changes
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
kjohn-msft
commented
Mar 13, 2025
feng-j678
approved these changes
Mar 13, 2025
rane-rajasi
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discrepancies between pro client checks and sources checks suggested there was mistake in recent code on non-security package classification on Apt.
The false-positive wasn't immediately apparent in past extensive testing and was self-identified.
This PR also addresses a related problem to the code that went in - additional folder cleanup is required to cleanup artifacts from dynamic source calculation. This is covered now.
Log:
42.core.log