Skip to content

Conversation

rane-rajasi
Copy link
Contributor

Fixes included in this PR:

  1. Do not use MaintenanceRunId to validate an incoming Auto Patching request
  2. MaxPatchPublishDate fails if healthstoreid contains additional '_'. For eg: Ideal healthstoreid "pub_off_sku_2020.09.29" is supported currently but if a healthstoreid, say "pub_off_sk_u_2020.09.29", comes in, maxpatchpublishdate calculation fails

@rane-rajasi rane-rajasi requested review from a team, najams, michellemcdaniel, kjohn-msft, nikhim-um and feng-j678 and removed request for a team March 18, 2025 22:00
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.49%. Comparing base (af59b83) to head (ab78eb1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/tests/Test_ExecutionConfig.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          99      100    +1     
  Lines       16287    16304   +17     
=======================================
+ Hits        15064    15080   +16     
- Misses       1223     1224    +1     
Flag Coverage Δ
python27 92.49% <95.65%> (+<0.01%) ⬆️
python39 92.49% <95.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

feng-j678
feng-j678 previously approved these changes Mar 18, 2025
Copy link
Contributor

@feng-j678 feng-j678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding debug to ln 113 is not required, but nice to have in case of future failures relate to health_store_id format

@rane-rajasi
Copy link
Contributor Author

@feng-j678, @kjohn-msft code coverage shows changes in this PR are missing coverage, however the detailed report does not have anything missing within these changes. Why is this happening?
image

image

feng-j678
feng-j678 previously approved these changes Mar 20, 2025
@feng-j678 feng-j678 merged commit 5faac3e into master Mar 24, 2025
7 checks passed
@feng-j678 feng-j678 deleted the rarane-bugfix branch March 24, 2025 22:14
@rane-rajasi rane-rajasi mentioned this pull request Apr 25, 2025
rane-rajasi added a commit that referenced this pull request Apr 25, 2025
This release includes:
[x] Engg. hygiene: Remove TelemetryWriter related log noise
[#312](#312)
[x] Bugfix: Mitigate external Ubuntu Pro Client issue
[#308](#308)
[x] Feature: Adding support for Azure Linux 2.0 in Tdnf Package Manager
[#311](#311)
[x] Eng. sys: Upgrade CICD pipeline from Python 3.9 to Python 3.12
[#309](#309)
[x] Coverage: Increase code coverage - TimerManager and ServiceManager
[#307](#307)
[x] Bugfix: Unit tests broken in Python 3.12
[#306](#306)
[x] Feature: Adding Azure Linux 3.0 Base Support
[#293](#293)
[x] Bugfix: Retry Handler to Prevent Unbounded Retries while trying to
Mitigate YUM Update Errors
[#303](#303)
[x] BugFix: CentOS VMs not installing patches during Auto Patching
[#298](#298)
[x] Bugfix: Auto-assessment - Restricting execution permissions to root
user/ owner
[#299](#299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants