Feature: Increase max OS version to support Ubuntu Pro Client 22.04 #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into hotfix/version_comparator_ubuntupro_version pull master changes.
…into change/spprt_pro_client_2204 pull master changes
feng-j678
requested review from
kjohn-msft,
rane-rajasi and
najams
as code owners
feng-j678
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 103 103
Lines 17528 17528
=======================================
Hits 16322 16322
Misses 1206 1206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feng-j678
changed the title
kjohn-msft
changed the title
…into change/spprt_pro_client_2204 pull master changes
|
The screenshot in the PR actually shows 1 of 2 reasons why we were holding back expanding it - And one part of a 2+ part customer CRI generator from last year and ongoing. Which is why this is being done -- |
|
Cancelling PR as coverage exists already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Increase max os version to support for ubuntu pro client 22.04
[x] core ut:
[x] handler ut: