Bugfix: Fixing Bootstrapper UT failure with Python 2.7 #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rane-rajasi
requested review from
a team,
najams,
michellemcdaniel,
kjohn-msft,
nikhim-um and
Copilot
and removed request for
a team,
najams,
michellemcdaniel and
nikhim-um
There was a problem hiding this comment.
Pull Request Overview
This PR fixes unit test failures on Python 2.7 by removing a type-annotated __init__ override in the TestBootstrapper class, allowing it to use the default unittest.TestCase constructor.
- Removed custom
__init__method with Python 3 type annotation. - Restored reliance on
unittest.TestCase’s built-in constructor for compatibility.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 93.77% 93.77% -0.01%
==========================================
Files 103 103
Lines 17926 17924 -2
==========================================
- Hits 16811 16809 -2
Misses 1115 1115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kjohn-msft
changed the title
kjohn-msft
added
engg. hygiene
kjohn-msft
approved these changes
May 19, 2025
michellemcdaniel
approved these changes
May 19, 2025
Merged
rane-rajasi
added a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.