chore(all): Some general code clean up (#4431)

* chore(all): Some general code clean up

* chore(all): Some general code clean up

.eslintrc.json

@@ -85,13 +85,7 @@
             "ignoreList": ["foo"]
           }
         ],
-        "no-param-reassign": [
-          "error",
-          {
-            "props": true,
-            "ignorePropertyModificationsFor": ["state"]
-          }
-        ],
+        "no-param-reassign": "off",
         "formatjs/enforce-default-message": ["error", "literal"],
         "formatjs/enforce-description": ["error", "literal"],
         "formatjs/no-multiple-whitespaces": [1],

.husky/pre-commit

@@ -1,9 +1,5 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npm run extract
-npm run compile:loc
-npm run compile:loc:psuedo
 npx lint-staged
-git add .
 

apps/vs-code-designer/src/app/utils/funcCoreTools/funcHostTask.ts

@@ -29,7 +29,7 @@ export function isFuncHostTask(task: vscode.Task): boolean {
   const commandLine: string | undefined = task.execution && (task.execution as vscode.ShellExecution).commandLine;
   if (task.definition.type == 'shell') {
     const command = (task.execution as vscode.ShellExecution).command?.toString();
-    const funcRegex = new RegExp('\\$\\{config:azureLogicAppsStandard\\.funcCoreToolsBinaryPath\\}');
+    const funcRegex = /\$\{config:azureLogicAppsStandard\.funcCoreToolsBinaryPath\}/;
     // check for args?
     return funcRegex.test(command);
   }

apps/vs-code-designer/src/package.json

@@ -39,12 +39,8 @@
         }
       ],
       "activation": {
-        "onFetch": [
-          "microsoft.web/sites"
-        ],
-        "onResolve": [
-          "microsoft.web/sites"
-        ]
+        "onFetch": ["microsoft.web/sites"],
+        "onResolve": ["microsoft.web/sites"]
       }
     },
     "commands": [
@@ -723,28 +719,17 @@
           "azureLogicAppsStandard.projectRuntime": {
             "scope": "resource",
             "type": "string",
-            "enum": [
-              "~4",
-              "~3"
-            ],
+            "enum": ["~4", "~3"],
             "description": "The default version of the Azure Functions runtime to use when performing operations like \"Create New Logic App\".",
-            "enumDescriptions": [
-              "Azure Functions v4",
-              "Azure Functions v3 (.NET Core)"
-            ]
+            "enumDescriptions": ["Azure Functions v4", "Azure Functions v3 (.NET Core)"]
           },
           "azureLogicAppsStandard.projectLanguage": {
             "scope": "resource",
             "type": "string",
-            "enum": [
-              "JavaScript",
-              "C#"
-            ],
+            "enum": ["JavaScript", "C#"],
             "readOnly": true,
             "description": "The default language to use when performing operations like \"Create New Workflow\".",
-            "enumDescriptions": [
-              ""
-            ]
+            "enumDescriptions": [""]
           },
           "azureLogicAppsStandard.deploySubpath": {
             "scope": "resource",
@@ -856,11 +841,7 @@
           },
           "azureLogicAppsStandard.projectOpenBehavior": {
             "type": "string",
-            "enum": [
-              "AddToWorkspace",
-              "OpenInNewWindow",
-              "OpenInCurrentWindow"
-            ],
+            "enum": ["AddToWorkspace", "OpenInNewWindow", "OpenInCurrentWindow"],
             "description": "The behavior to use after creating a new project. The options are \"AddToWorkspace\", \"OpenInNewWindow\", or \"OpenInCurrentWindow\"."
           },
           "azureLogicAppsStandard.show64BitWarning": {
@@ -989,15 +970,8 @@
   },
   "homepage": "https://azure.microsoft.com/services/logic-apps/",
   "license": "SEE LICENSE IN LICENSE.md",
-  "categories": [
-    "Azure"
-  ],
-  "keywords": [
-    "Azure",
-    "Logic App",
-    "serverless",
-    "multi-root ready"
-  ],
+  "categories": ["Azure"],
+  "keywords": ["Azure", "Logic App", "serverless", "multi-root ready"],
   "preview": false,
   "publisher": "ms-azuretools",
   "icon": "assets/logicapp.png",

biome.json

@@ -21,7 +21,35 @@
     "ignore": ["dist/*", "test-results/*", "tmp/*", "playwright-report/*"]
   },
   "linter": {
-    "enabled": false
+    "enabled": true,
+    "rules": {
+      "recommended": false,
+      "performance": {
+        "all": true,
+        "noDelete": "off",
+        "noAccumulatingSpread": "off"
+      },
+      "a11y": {
+        "all": false
+      },
+      "complexity": {
+        "all": false
+      },
+      "correctness": {
+        "all": false
+      },
+      "security": {
+        "all": true
+      },
+      "style": {
+        "all": false
+      },
+      "suspicious": {
+        "all": false
+      }
+    },
+    "include": ["libs/**/*.ts", "libs/**/*.tsx", "apps/**/*.ts", "apps/**/*.tsx"],
+    "ignore": ["**/__test__/**"]
   },
   "organizeImports": {
     "enabled": false,

libs/data-mapper/src/lib/components/configPanel/SelectExistingSchema.tsx

@@ -1,7 +1,7 @@
 import type { RootState } from '../../core/state/Store';
 import { FileDropdown } from '../fileDropdown/fileDropdown';
 import { SchemaType } from '@microsoft/logic-apps-shared';
-import React, { useMemo } from 'react';
+import { useMemo } from 'react';
 import { useIntl } from 'react-intl';
 import { useSelector } from 'react-redux';
 

libs/designer-ui/src/lib/card/images/dynamicsvgs/allowdroptarget.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface AllowDropTargetProps {
   fill: string;
 }

libs/designer-ui/src/lib/card/images/dynamicsvgs/blockdroptarget.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface BlockDropTargetProps {
   fill: string;
 }

libs/designer-ui/src/lib/card/images/dynamicsvgs/trafficlightsvgs.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface DotProps {
   fill: string;
 }

libs/designer-ui/src/lib/editor/monaco/index.tsx

@@ -214,7 +214,7 @@ export const MonacoEditor = forwardRef<editor.IStandaloneCodeEditor, MonacoProps
       id: 'open-tokenpicker',
       label: 'Open TokenPicker',
       keybindings: [512 | 85],
-      run: function (): void | Promise<void> {
+      run: (): void | Promise<void> => {
         openTokenPicker?.();
       },
     };

libs/designer-ui/src/lib/floatingactionmenu/floatingactionmenuoutputs/index.tsx

@@ -9,7 +9,6 @@ import { StringEditor } from '../../editor/string';
 import type { FloatingActionMenuItem } from '../floatingactionmenubase';
 import { FloatingActionMenuBase } from '../floatingactionmenubase';
 import { clone, ValidationErrorCode, ValidationException } from '@microsoft/logic-apps-shared';
-import React from 'react';
 import { useIntl } from 'react-intl';
 
 type DynamicallyAddedParameterOutputsProperties = {

libs/designer-ui/src/lib/monitoring/values/html.tsx

@@ -15,6 +15,7 @@ export const HtmlValue: React.FC<ValueProps> = (props) => {
         {displayName}
       </label>
       <div aria-labelledby={id} className="msla-trace-value-text msla-trace-value-html-table">
+        {/* biome-ignore lint/security/noDangerouslySetInnerHtml: This is needed in this case but we should investigate other ways of doing it */}
         <table dangerouslySetInnerHTML={{ __html }} tabIndex={0}></table>
       </div>
     </section>

libs/designer-ui/src/lib/querybuilder/Group.tsx

@@ -377,7 +377,7 @@ export const Group = ({
                 items={[]}
                 overflowItems={groupMenuItems}
                 onRenderOverflowButton={onRenderOverflowButton}
-                onRenderItem={function (_item: IOverflowSetItemProps) {
+                onRenderItem={(_item: IOverflowSetItemProps) => {
                   throw new Error('No items in overflowset');
                 }}
               />

libs/designer-ui/src/lib/querybuilder/Row.tsx

@@ -300,7 +300,7 @@ export const Row = ({
           items={[]}
           overflowItems={rowMenuItems}
           onRenderOverflowButton={onRenderOverflowButton}
-          onRenderItem={function (_item: IOverflowSetItemProps) {
+          onRenderItem={(_item: IOverflowSetItemProps) => {
             throw new Error('No items in overflowset');
           }}
         />

libs/designer-ui/src/lib/recommendation/documentationItem.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 export type DocLinkClickedEventHandler = () => void;
 
 export interface DocumentationItemProps {

libs/designer-ui/src/lib/settings/settingsection/__tests__/settingtoggle.spec.tsx

@@ -1,6 +1,5 @@
 import type { SettingToggleProps } from '../settingtoggle';
 import { SettingToggle } from '../settingtoggle';
-import * as React from 'react';
 import * as ReactShallowRenderer from 'react-test-renderer/shallow';
 
 describe('ui/settings/settingtoggle', () => {

libs/designer-ui/src/lib/settings/settingsection/dictionary/simpledictionary.tsx

@@ -1,6 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
 import type { EventHandler } from '../../../eventhandler';
-import { Label } from '../../../label';
 import { useId } from '../../../useId';
 import { SimpleDictionaryItem } from './simpledictionaryitem';
 import type { SimpleDictionaryRowModel, SimpleDictionaryChangeModel } from './simpledictionaryitem';

libs/designer-ui/src/lib/tip/index.tsx

@@ -1,7 +1,6 @@
 import type { IButtonProps } from '@fluentui/react';
 import { Callout, CommandButton, DirectionalHint } from '@fluentui/react';
 import type { ReactNode } from 'react';
-import React from 'react';
 
 export const DEFAULT_TIP_GAP_SPACE = 0;
 export const DEFAULT_DIRECTIONAL_HINT = DirectionalHint.leftCenter;

libs/designer-ui/src/lib/tokenpicker/index.tsx

@@ -1,3 +1,4 @@
+import type { editor } from 'monaco-editor';
 import type { ValueSegment } from '../editor';
 import { CLOSE_TOKENPICKER } from '../editor/base/plugins/CloseTokenPicker';
 import type { ExpressionEditorEvent } from '../expressioneditor';
@@ -15,7 +16,6 @@ import type { ICalloutContentStyles, ISearchBox, PivotItem } from '@fluentui/rea
 import { SearchBox, DirectionalHint, Callout } from '@fluentui/react';
 import { useLexicalComposerContext } from '@lexical/react/LexicalComposerContext';
 import type { LexicalEditor, NodeKey } from 'lexical';
-import type { editor } from 'monaco-editor';
 import { useEffect, useRef, useState } from 'react';
 import { useIntl } from 'react-intl';
 

libs/designer-ui/src/lib/workflowparameters/__tests__/workflowparametersButtons.spec.tsx

@@ -1,6 +1,5 @@
 import type { EditOrDeleteButtonProps } from '../workflowparametersButtons';
 import { EditOrDeleteButton } from '../workflowparametersButtons';
-import * as React from 'react';
 import * as ReactShallowRenderer from 'react-test-renderer/shallow';
 
 describe('ui/workflowparameters/workflowparametersButtons', () => {

libs/designer/src/lib/core/state/operation/operationSelector.ts

@@ -120,14 +120,7 @@ export const useAllOperationErrors = () => useSelector(createSelector(getOperati
 
 export const useParameterValidationErrors = (nodeId: string) => {
   const allParameters = useOperationInputParameters(nodeId);
-  return useMemo(
-    () =>
-      allParameters
-        .map((parameter) => parameter.validationErrors)
-        .flat()
-        .filter((error) => error),
-    [allParameters]
-  );
+  return useMemo(() => allParameters.flatMap((parameter) => parameter.validationErrors).filter((error) => error), [allParameters]);
 };
 
 export const useNodesInitialized = () => useSelector(createSelector(getOperationState, (state) => state.loadStatus.nodesInitialized));

libs/designer/src/lib/ui/connections/dynamicsvgs/allowdroptarget.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface AllowDropTargetProps {
   fill: string;
 }

libs/designer/src/lib/ui/connections/dynamicsvgs/blockdroptarget.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface BlockDropTargetProps {
   fill: string;
 }

libs/designer/src/lib/ui/connections/dynamicsvgs/gripper.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface GripperProps {
   fill: string;
 }

libs/designer/src/lib/ui/connections/dynamicsvgs/trafficlightsvgs.tsx

@@ -1,5 +1,3 @@
-import * as React from 'react';
-
 interface DotProps {
   fill: string;
 }

libs/designer/src/lib/ui/panel/connectionsPanel/allConnections/connectorConnectionsCard.tsx

@@ -37,9 +37,7 @@ export const ConnectorConnectionsCard: React.FC<ConnectorConnectionsCardProps> =
   const hasErrors = useMemo(() => {
     if (disconnectedNodes?.length > 0) return true;
     const nodesWithErrors = Object.keys(allErrors);
-    const connectorNodeIds = Object.values(connectionRefs)
-      .map((obj) => obj.nodes)
-      .flat();
+    const connectorNodeIds = Object.values(connectionRefs).flatMap((obj) => obj.nodes);
     return nodesWithErrors.some((nodeId) => connectorNodeIds.includes(nodeId));
   }, [allErrors, connectionRefs, disconnectedNodes?.length]);
 

libs/logic-apps-shared/src/utils/src/lib/helpers/__test__/functions.spec.ts

@@ -889,6 +889,17 @@ describe('lib/helpers/functions', () => {
       expect(hexToRgbA(hexColor)).toBe('rgba(0,51,255, 1)');
     });
 
+    it('returns 0 for opacity when opacity is 0', () => {
+      const hexColor = '#0033FF';
+      // Note: This actually would have failed before the fix
+      expect(hexToRgbA(hexColor, 0)).toBe('rgba(0,51,255, 0)');
+    });
+
+    it('returns 0.5 for opacity when opacity is 0', () => {
+      const hexColor = '#0033FF';
+      expect(hexToRgbA(hexColor, 0.5)).toBe('rgba(0,51,255, 0.5)');
+    });
+
     it('returns rgb value for the incomplete hex value', () => {
       const hexColor = '#03F';
       expect(hexToRgbA(hexColor)).toBe('rgba(0,51,255, 1)');