Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Allow script generation without connections and click in project root #4976

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

ccastrotrejo
Copy link
Contributor

This pull request includes changes to the generateDeploymentScripts.ts file in the vs-code-designer app. The changes primarily focus on simplifying the code and improving the readability. The projectRoot parameter has been removed from the generateDeploymentScripts function, and it is now defined within the function itself. The connectionsData object is now created using a ternary operator to avoid unnecessary conditionals. The window import has been removed and replaced with vscode.window for better clarity.

  • Removed the projectRoot parameter from the generateDeploymentScripts function and defined it within the function using vscode.Uri.file(projectPath).
  • Simplified the creation of the connectionsData object using a ternary operator. Replaced window.showInformationMessage with vscode.window.showInformationMessage for better clarity.
  • Replaced window.showErrorMessage with vscode.window.showErrorMessage for better clarity.

Fixes #4924

@ccastrotrejo ccastrotrejo changed the title fix(vscode): Allow script generation without connections and click in project root. fix(vscode): Allow script generation without connections and click in project root Jun 13, 2024
@ccastrotrejo ccastrotrejo enabled auto-merge (squash) June 13, 2024 18:42
@ccastrotrejo ccastrotrejo merged commit cef9348 into main Jun 17, 2024
12 checks passed
@Eric-B-Wu Eric-B-Wu deleted the ccastrotrejo/fixScriptsss branch June 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during deployment script generation: Error in setupWizardScriptContext
2 participants