fix(vscode): Fix designtime local.settings overwriting #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccastrotrejo
changed the title
rllyy97
approved these changes
Jun 14, 2024
ccastrotrejo
added a commit
that referenced
this pull request
Jun 24, 2024
* Add function to get local.settings schema * Add test for local settings schema * Redirect import to node_modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes primarily aimed at refactoring the project's settings management, improving code readability, and enhancing the test coverage. The modifications include consolidating imports, replacing hardcoded values with constants, adjusting the structure of local settings, and adding new test cases.
Consolidated imports from 'vscode' into a single line.
Replaced hardcoded values with constants and expanded the import list for better readability.
Similar changes were made as in
ScriptProjectCreateStep.tsfor code consistency.The local settings structure was adjusted to include a design time flag and improved key-value mapping. The function
getLocalSettingsSchemawas added to generate the schema based on the project path and design time flag.New test cases were added to verify the correct behavior of the
getLocalSettingsSchemafunction.The settings file content was replaced with the
getLocalSettingsSchemafunction.Removed unused settings file content.
Replaced hardcoded settings file content with the
getLocalSettingsSchemafunction.