Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Switch to cloud-provider-azure for cloud-controller-manager image #1915

Closed
feiskyer opened this issue Sep 6, 2019 · 10 comments · Fixed by #2161
Closed

Switch to cloud-provider-azure for cloud-controller-manager image #1915

feiskyer opened this issue Sep 6, 2019 · 10 comments · Fixed by #2161
Assignees
Labels
bug Something isn't working
Milestone

Comments

@feiskyer
Copy link
Member

feiskyer commented Sep 6, 2019

Because of kubernetes/kubernetes#81029, cloud-controller-manager image won't be released since v1.16.beta.x.

We should switch to hyperkube image when configuring cloud-controller-manager.

Update: I didn't notice there's a change also dropping cloud-controller-manager support in hyperkube kubernetes/kubernetes#81219. After this PR, we could only use the ccm image built from cloud-provider-azure repo.

Refer the example manifests here: https://github.com/kubernetes/cloud-provider-azure/tree/master/examples/out-of-tree.

@feiskyer feiskyer added the bug Something isn't working label Sep 6, 2019
@feiskyer
Copy link
Member Author

feiskyer commented Sep 6, 2019

@ritazh Could you help to take a look at this?

/assign @ritazh

@jackfrancis jackfrancis changed the title Switch to hyperkube for cloud-controller-manager image Switch to cloud-provider-azure for cloud-controller-manager image Sep 19, 2019
@jackfrancis
Copy link
Member

@feiskyer FYI updated the issue title

@feiskyer
Copy link
Member Author

Just build and push images for Kubernetes v1.16:

mcr.microsoft.com/k8s/core/azure-cloud-controller-manager:v0.3.0
mcr.microsoft.com/k8s/core/azure-cloud-node-manager:v0.3.0

Their example manifests could be found at https://github.com/kubernetes/cloud-provider-azure/blob/master/examples/out-of-tree/cloud-node-manager.yaml and https://github.com/kubernetes/cloud-provider-azure/blob/master/examples/out-of-tree/cloud-controller-manager.yaml.

@jackfrancis could you help to the images as well as the new cloud-node-manager for v1.16.0 clusters?

@jackfrancis
Copy link
Member

Thx @feiskyer will do!

@ritazh
Copy link
Member

ritazh commented Oct 15, 2019

@jchauncey should we move to mcr.microsoft.com/oss/k8s now? It's going to be harder once the image is part of this code.

@mboersma
Copy link
Member

mboersma commented Oct 15, 2019

I have a PR I'm about to put out there that assumes the URLs that @feiskyer mentioned above, and AKS Engine already has a constant in there MCRKubernetesImageBase = mcr.microsoft.com/k8s/core/. (This was added in #2050.)

Just sayin'–we can change these but as Rita said it becomes increasingly painful.

@jchauncey
Copy link
Contributor

let me submit the pr to mcr to hook up our /oss path. once that is merged its easy to build the these 2 images and publish them to the new endpoint and just use that.

@ritazh
Copy link
Member

ritazh commented Oct 18, 2019

Looks like we had some issues getting https://github.com/microsoft/mcr/pull/757 merged.

Until the new paths get sorted out, to unblock this PR and few other ones, maybe we can use the mcr.microsoft.com/k8s/core/ one for now then update with the new image path in a future PR? WDYT?

@feiskyer
Copy link
Member Author

Until the new paths get sorted out, to unblock this PR and few other ones, maybe we can use the mcr.microsoft.com/k8s/core/ one for now then update with the new image path in a future PR? WDYT?

+1.

@jchauncey
Copy link
Contributor

yeah sounds good to me

@mboersma mboersma added this to the v0.44.0 milestone Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
5 participants