This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Add 1.24 support #4813
Merged
feat: Add 1.24 support #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
jsturtevant
reviewed
Jan 19, 2022
| // Remove dockershim related flags in v1.24 and up | ||
| if common.IsKubernetesVersionGe(v, "1.24.0-alpha") { | ||
| for _, key := range []string{"--image-pull-progress-deadline", "--network-plugin"} { | ||
| delete(k, key) |
There was a problem hiding this comment.
was going to ask if these should these removed or added back in if less than 1.24, but from above it looks like the pattern is to remove the flags
There was a problem hiding this comment.
Yea, I had the same question and was following previous examples.
|
/lgtm |
jsturtevant
approved these changes
Jan 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Rossetti marosset@microsoft.com
Reason for Change:
Some tests in kubernetes/kubernetes which rely on aks-engine to provision clusters have started to fail due to the removal of some kubelet flags. This PR adds support for aks-engine to build 1.24 clusters and removes the deprecated kubelet flags.
Note: There has not been any builds of kubernetes v1.24 yet. The versions referenced in this PR are just a placeholder so we can build clusters from kubernetes/kubernetes at HEAD
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: