Add retry logic for 409 response with specific Conflict error code #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2025 14:17
Enhanced the `CommonRetryPolicy` class to handle retries for HTTP 409 Conflict responses when the error code matches "Conflict". - Added a new condition to the `ShouldRetry` method's `switch` statement to check for 409 status and use the `HasConflictError` method. - Introduced the `HasConflictError` method to encapsulate logic for identifying "Conflict" error codes using `TryGetErrorCode`. - Reused the existing `TryGetErrorCode` method to support the new `HasConflictError` logic. These changes improve the robustness of the retry policy by handling additional conflict scenarios.
Updated `CommonRetryPolicy` to refine retry conditions for HTTP 409 responses. Added `HasOperationOnTheApiIsInProgressMessage` to check for specific API state messages. Introduced `TryGetMessage` for extracting the "message" property from response content. These changes improve retry precision and robustness by ensuring retries occur only when appropriate.
guythetechie
approved these changes
Sep 18, 2025
|
Thank you for the fast replies. We have a lot of issues with this 409 error so hopefully this will be released soon. |
|
Thank for the PR. I will be releasing the changes shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 422 and 409 errors are retried in combination with the
ManagementApiRequestFailederror code as discussed in issue #497.In our case, the publisher is failing randomly on an API with a response that is not handled in the retry policy.
Sample response:
Content: {"error":{"code":"Conflict","message":"Operation on the API is in progress","details":null}}.This pull request improves the retry logic for HTTP requests in
tools/code/common/Http.cs, specifically for handling certain API conflict scenarios. The main change is to add more granular checks for when a retry should occur, particularly for 409 Conflict responses related to ongoing API operations.Enhanced retry logic for HTTP requests:
ShouldRetryInnerto retry when a 409 Conflict response has both the "Conflict" error code and the "Operation on the API is in progress" message.New helper methods for response inspection:
HasConflictErrorto check if the response error code is "Conflict".HasOperationOnTheApiIsInProgressMessageto check if the response error message is "Operation on the API is in progress".TryGetMessageto extract the error message from the response JSON.These changes make the retry logic more robust and specific, reducing unnecessary retries and better handling API concurrency scenarios.