Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serial Console] Migrate to a new authentication flow #7653

Merged
merged 24 commits into from
Jun 12, 2024

Conversation

dominikabobik
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 22, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented May 22, 2024

Serial Console

Copy link

github-actions bot commented May 22, 2024

For more info about extension versioning, please refer to Extension version schema

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 22, 2024
@yonzhan yonzhan requested review from jsntcy and kairu-ms May 22, 2024 23:38
Dominika Bobik added 2 commits May 24, 2024 14:55
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 24, 2024
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
@kairu-ms kairu-ms merged commit 5bc43ac into Azure:main Jun 12, 2024
16 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ serial-console ] : https://dev.azure.com/azclitools/release/_build/results?buildId=164632&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
* changed readme

* added slag

* tests finally work

* auth flow changes

* working stage

* removed semicolon

* formatting

* removed debug statements from tests

* formatting

* formatting v3456

* fixed typo

* send token after first message is recieved

* remove flag

* changed version

* rebase leftover

* recorsdings tests

* updated tests

* tests

* version update

* change to trigger build

* Update src/serial-console/azext_serialconsole/custom.py

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

---------

Co-authored-by: Dominika Bobik <dbobik@microsoft.com>
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants