chore: do not use network_plugin default from sdk #7766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @tyler-lloyd, |
|
Hi @tyler-lloyd, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
FumingZhang
reviewed
Jul 2, 2024
paulgmiller
reviewed
Jul 2, 2024
|
Failures in the CI check are not related to the change, will fix in another PR #7775 |
|
#7775 merged, please rebase from main |
tyler-lloyd
force-pushed
the
networkplugindefaults
branch
from
92b68f8 to
c4827a4
Compare
|
@FumingZhang - looks like CI is passing now. thanks for the fix. |
FumingZhang
approved these changes
Jul 9, 2024
|
@zhoxing-ms PTAL |
yanzhudd
approved these changes
Jul 10, 2024
liorstauber
pushed a commit
to liorstauber/azure-cli-extensions
that referenced
this pull request
Jul 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
the cli should not set network_plugin defaults. it should let the AKS RP handle defaulting.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.