remove vendor again #1835
Merged
remove vendor again #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
thatmattlong,
ramiro-gamarra,
timraymond and
a team
and removed request for
a team
|
just padding my delta LOC |
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com>
timraymond
approved these changes
Mar 6, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* remove vendor (again) Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * update mockgen usage for novendor Signed-off-by: GitHub <noreply@github.com> --------- Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> Signed-off-by: GitHub <noreply@github.com>
rbtr
added a commit
that referenced
this pull request
Sep 8, 2023
* remove vendor (again) Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * update mockgen usage for novendor Signed-off-by: GitHub <noreply@github.com> --------- Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> Signed-off-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The vendor dir was added back to try to resolve issues with Windows builds - this was addressed via a different solution in #1820 (we only build on Linux and set the GOOS to crosscompile appropriately), and we can remove the vendor again and let go mod do its thing.
Issue Fixed:
Requirements:
Notes: