fix: reconcile initial state from CRD regardless of existing podInfo #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
fix/pending-ip-init
branch
3 times, most recently
from
6ea3d8e
to
6687fb0
Compare
neaggarwMS
changed the title
rbtr
force-pushed
the
fix/pending-ip-init
branch
from
6687fb0
to
b52cbf8
Compare
rbtr
changed the title
rbtr
force-pushed
the
fix/pending-ip-init
branch
from
01cea77
to
a53ccb7
Compare
rbtr
force-pushed
the
fix/pending-ip-init
branch
from
a53ccb7
to
51576b7
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
force-pushed
the
fix/pending-ip-init
branch
from
51576b7
to
c0054d1
Compare
tamilmani1989
approved these changes
Jun 22, 2023
thatmattlong
approved these changes
Jun 22, 2023
neaggarwMS
reviewed
Jun 22, 2023
| } | ||
| return errors.Wrap(err, "failed to initialize CNS state") | ||
| }, retry.Context(ctx), retry.Delay(initCNSInitalDelay), retry.MaxDelay(time.Minute)) | ||
| logger.Printf("Reconciling initial CNS state") |
There was a problem hiding this comment.
can you add podInfoProvider stat in the log? or add at least length
There was a problem hiding this comment.
it is logged once we get to reconcileNCState
jaer-tsun
pushed a commit
to jaer-tsun/azure-container-networking
that referenced
this pull request
Jul 17, 2023
…zure#2022) * fix: reconcile initial state from CRD regardless of existing podInfo Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * fix: add test for no state and pending release in NNC Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * fix: add test for restoring state and pending release in NNC Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fix for bug where CNS may incorrectly initialize after a Node reboot
Issue Fixed:
A bug in CNS initialization can lead to an IP being leaked and Assigned to Pods even though it has been deallocated.
Requirements:
Notes: