Fixed windows CNI issues #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhanrm
reviewed
Aug 9, 2018
cni/network/network_windows.go
Outdated
| @@ -55,7 +56,8 @@ func handleConsecutiveAdd(containerId, endpointId string, nwInfo *network.Networ | |||
| return result, nil | |||
| } | |||
|
|
|||
| return nil, nil | |||
| err = fmt.Errorf("endpoint %v not found", endpointId) | |||
There was a problem hiding this comment.
Try to return the error returned from the platform instead of constructing a new one.
madhanrm
reviewed
Aug 9, 2018
| defer func() { | ||
| if err != nil { | ||
| log.Printf("[net] HNSEndpointRequest DELETE id:%v", hnsResponse.Id) | ||
| hnsResponse, err := hcsshim.HNSEndpointRequest("DELETE", hnsResponse.Id, "") |
There was a problem hiding this comment.
Hopefully the IPAddress is also released from the IPAM following this somewhere in CNI
There was a problem hiding this comment.
yes it will free up..will test once.
|
Does this resolve #218? |
|
yes it should |
|
/lgtm Try following scenarios () Deploy a service |
sharmasushant
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: