-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisableServerCertificateValidation: Fixes Default HttpClient to honor DisableServerCertificateValidation #4294
DisableServerCertificateValidation: Fixes Default HttpClient to honor DisableServerCertificateValidation #4294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
… and DocumentClient use a consistency way
…on and ServerCertificateCustomValidationCallback combination - Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking)
0735a1b
to
f78efff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
495669d
Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0dced98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ideal if we could track this under a GitHub issue.
… DisableServerCertificateValidation (#4294) * DisableServerCertificateValidation: Fix ensuring that both HttpClient and DocumentClient use a consistency way * E2E Emulator test coverage * - Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination - Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking) * Addressing comments * Fixing a warning * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Addressing commens * Undoing a change * Fixing UT * Renaming a test case name --------- Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
… DisableServerCertificateValidation (#4294) * DisableServerCertificateValidation: Fix ensuring that both HttpClient and DocumentClient use a consistency way * E2E Emulator test coverage * - Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination - Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking) * Addressing comments * Fixing a warning * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Addressing commens * Undoing a change * Fixing UT * Renaming a test case name --------- Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Description
When
DisableServerCertificateValidation
is set:ServerCertificateCustomValidationCallback
is conditionally set after validation when ConnectionPolicy is created. But HttpClient is created before ConnectionPolicy creation resulting in the configuration getting ignored.changes
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber