Skip to content

Conversation

clehene
Copy link
Contributor

@clehene clehene commented Jul 24, 2017


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@msftclas
Copy link

@clehene,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@coveralls
Copy link

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-0.8%) to 82.767% when pulling 8cc8ccd39b4a90f4dabf954e83076f447fab5064 on clehene:master into eb2d774 on Azure:master.

@begoldsm
Copy link
Contributor

@clehene it looks like there is still a bit of a race condition in your progress tracking test (at least in python 2.7). Can you take a look?

@clehene
Copy link
Contributor Author

clehene commented Jul 26, 2017

@begoldsm please see #182 and associated PR

@begoldsm
Copy link
Contributor

@clehene thank you so much! I just resolved the conflict the merge of #182 created in history.rst and the tests are now running. Once this completes successfully I will merge this as well.

Thanks again!

@coveralls
Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage remained the same at 83.414% when pulling 4ee61df882e7c4c6b97dec71fa91b0d1d77f22d7 on clehene:master into b42138f on Azure:master.

@clehene clehene force-pushed the master branch 2 times, most recently from eae03b0 to 3322a60 Compare July 27, 2017 01:08
@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 83.414% when pulling 3322a60 on clehene:master into b42138f on Azure:master.

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 83.414% when pulling 3322a60 on clehene:master into b42138f on Azure:master.

@begoldsm begoldsm merged commit 567ff28 into Azure:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants