Reporting non-existent orchestrations in start_new
#142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-python into djusto/orchestration-client-exception
cgillum
reviewed
Jun 24, 2020
cgillum
reviewed
Jun 25, 2020
cgillum
reviewed
Jun 25, 2020
|
I forgot to ask - how hard would it be to add a unit test for this? I know we're able to pretty easily mock the HTTP stuff in Durable JS but I'm not as familiar with the Python test setup. |
|
Hmmm, I'd have to investigate the unit testing setup a little more. Mocking HTTP requests is easy, and I've done it before for other projects, I just need to double check that our testing framework makes that easy to incorporate in a white-box test. I'll get back to you |
|
Heads up, added unit tests! Will merge now, thanks :) |
|
Excellent!!! Also, don't forget to delete your branch after each PR merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #141
We now throw an exception when start_new fails, whereas before we simply returned
None. In doing so, we avoid throwing an internal exception (server response 500) when callingclient.create_check_status_response.In practice, this meant that, before, users hitting an
HTTPTriggerwith a typo on the orchestration name would see an internal exception with little debug information. Now, we report the real cause of the error and suggest a fix: looking for typos.I would also love it if we could display this error, and others, as part of an HTTP response. Reading it on the terminal, while common practice, is not as nice, in my opinion.
Finally, this is also an error in Durable-JS.