Serialize False as a return value for orchestrators #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #155
This PR represented a simple change with important consequences, and some implications about coding style. Before, orchestrators failed to serialize their return value when it's value was
False
. The reason why is that we performed a faulty check in our serialization logic. The check was to avoid serializing aNone
value, but it was written as:In most cases, this is fine, because
None
values resolve toFalse
. However, this broke whenself._output
was literallyFalse
. A safer check isif self._output is not None
. We should consider a refactor where we rewrite all these "dangerous" checks into their safer alternative.I'm tracking that task here: #166