Skip to content

Added missing 'kind' field in TokenSource's serialized form #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Added missing 'kind' field in TokenSource's serialized form #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e6afcb
added missing 'kind' field in TokenSource's serialization form
davidmrdavid Oct 16, 2020
92a6529
small change for auth
davidmrdavid Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions azure/durable_functions/models/TokenSource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class ManagedIdentityTokenSource(TokenSource):
def __init__(self, resource: str):
super().__init__()
self._resource: str = resource
self._kind: str = "AzureManagedIdentity"

@property
def resource(self) -> str:
Expand All @@ -51,4 +52,5 @@ def to_json(self) -> Dict[str, Union[str, int]]:
"""
json_dict: Dict[str, Union[str, int]] = {}
add_attrib(json_dict, self, 'resource')
json_dict["kind"] = self._kind
return json_dict
11 changes: 11 additions & 0 deletions tests/models/test_TokenSource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from azure.durable_functions.models.TokenSource import ManagedIdentityTokenSource

def test_serialization_fields():
"""Validates the TokenSource contains the expected fields when serialized to JSON"""
token_source = ManagedIdentityTokenSource(resource="TOKEN_SOURCE")
token_source_json = token_source.to_json()

# Output JSON should contain a resource field and a kind field set to `AzureManagedIdentity`
assert "resource" in token_source_json.keys()
assert "kind" in token_source_json.keys()
assert token_source_json["kind"] == "AzureManagedIdentity"