Skip to content

Update samples #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2020
Merged

Update samples #236

merged 2 commits into from
Dec 8, 2020

Conversation

davidmrdavid
Copy link
Collaborator

A follow-up to #230 with an azure-cloud tested fan-out-fan-in sample and READMEs with working links

ConnorMcMahon
ConnorMcMahon approved these changes Dec 8, 2020
View reviewed changes
Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits, but otherwise a nice set of changes!

samples/fan_in_fan_out/HttpStart/__init__.py Outdated
async def main(req: func.HttpRequest, starter: str) -> func.HttpResponse:
client = df.DurableOrchestrationClient(starter)
payload = req.get_body()
payload: str = json.loads(req.get_body().decode())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is this change for?

It may be worth commenting why this is necessary, especially since this is a sample.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this is needed to load the JSON HTTP payload, which is otherwise generally interpreted as bytes. Added the comment!

@davidmrdavid davidmrdavid merged commit 9987f55 into dev Dec 8, 2020
@davidmrdavid davidmrdavid deleted the dajusto/docs-review branch December 8, 2020 19:52
@sgkim99
Copy link

sgkim99 commented Apr 26, 2023

samples/fan_in_fan_out/E2_GetFileList/init.py
I followed this fan-in-fan-out samples and works great for local version(Windows host and Python).
But when I deploy this function app and then trigger with my PC local directory(ex. D:\Test), nothing happens.
And found that if I trigger with path provided in the article(""/home/site/wwwroot"), functions server local file is backed-up.
Could you show me how to back up local PC directory for deploy version?
Any hints are highly appreciated. Many Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ConnorMcMahon ConnorMcMahon ConnorMcMahon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidmrdavid @sgkim99 @ConnorMcMahon