-
Notifications
You must be signed in to change notification settings - Fork 64
Validate Bundles V2 usage in initialization script #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
67aa95b
Validate bundles, read emojis
davidmrdavid 8f9fd08
Merge branch 'dev' into dajusto/validate-bundles
davidmrdavid ad00214
remove unused import
davidmrdavid f9345f9
Add extra validation to host.json reading
davidmrdavid e32b764
Merge branch 'dajusto/validate-bundles' of https://github.com/Azure/a…
davidmrdavid 6381b1f
Merge branch 'dev' into dajusto/validate-bundles
davidmrdavid 37d74a7
Merge branch 'dev' into dajusto/validate-bundles
davidmrdavid 24c5b3e
Merge branch 'dajusto/validate-bundles' of https://github.com/Azure/a…
davidmrdavid bd2c557
Extra line for flake8
davidmrdavid 49cf3c2
Apply lint fix for flake8
davidmrdavid 8543919
Avoid validatation of extension bundles in tests
davidmrdavid 6248d57
Apply lint fix
davidmrdavid 4af91c5
Apply further lint fixes
davidmrdavid db308c6
Improve commenting
davidmrdavid 763d50d
Merge branch 'dev' into dajusto/validate-bundles
davidmrdavid ad0a198
Rewrite error message to be python-durable specific
davidmrdavid 1985d61
Merge branch 'dajusto/validate-bundles' of https://github.com/Azure/a…
davidmrdavid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some small subset of customers may have more specific version ranges, like "[1.2, 2.0.0)" due to pinning during regressions. It's an edge case, but we may want to ask @narensoni if we should cover it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this for now, since it's better than nothing, but track this follow-up here: #247