Increase sequence number in fire-and-forget APIs and fix ContinueAsNew Serialization #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ConnorMcMahon: I found another small bug, thankfully before the release :) |
davidmrdavid
changed the title
ConnorMcMahon
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #302
In the case of signalEntity, we need to increase the internal sequenceID for the following APIs to be correctly processing in our linear-pass algorithm. This PR adds that change.
Additionally, I realized that in the pre-existing SDK, continueAsNew input strings weren't getting correctly serialized (they also need to be stringified) so this PR fixes that.