Shim NetheriteProviderFactory DI to avoid .NET8 regression #10274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10271
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
This PR addresses a breaking change in .NET 8 DI which impacts Netherite. Specifically,
ActivatorUtilitiesConstructorAttribute
no longer workers as expected, leading to an ambiguous constructor exception when trying to resolveNetheriteProviderFactory
. The Netherite package has addressed this issue in a later version, but we are concerned about impact for customers not on latest netherite package. This PR aims to address that by looking for this impacted type and replacing the service descriptor with one explicitly targeting the preferred ctor.