Skip to content

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Jul 24, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Updates and organizes some nuget packages.

Output of Verify_DepsJsonChanges:

IMPORTANT: The dependencies in WebHost have changed and MUST be reviewed before proceeding. Please follow up with brettsam, fabiocav or mathewc for approval.

Previous file: C:\repos\func\host-2\out\bin\WebJobs.Script.Tests\debug_net6.0\Microsoft.Azure.WebJobs.Script.WebHost.deps.json
New file:      C:\repos\func\host-2\out\bin\WebJobs.Script.WebHost\debug_net6.0\Microsoft.Azure.WebJobs.Script.WebHost.deps.json

  Changed:
    - Azure.Security.KeyVault.Secrets.dll: 4.2.0.0/4.200.21.31503 -> 4.6.0.0/4.600.24.11403

  Removed:

  Added:
    - System.Formats.Asn1.dll: 6.0.0.0/6.0.3224.31407

@jviau jviau requested a review from a team as a code owner July 24, 2024 22:24
@jviau jviau changed the title Update nuget packages [in-proc] Update nuget packages Jul 24, 2024
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was System.Formats.Asn1 flagged as an addition and not a change by the test?

@jviau
Copy link
Contributor Author

jviau commented Jul 25, 2024

Was System.Formats.Asn1 flagged as an addition and not a change by the test?

Yeah, that is the output of the test exactly. If you look at the deps file, it is not an addition. Maybe the test is confused as it is promoted to a direct dependency now?

@jviau jviau requested a review from fabiocav July 26, 2024 19:43
@jviau jviau force-pushed the jviau/in-proc/package-updates branch from a595b8b to 61051ec Compare July 29, 2024 17:39
@jviau jviau mentioned this pull request Jul 29, 2024
9 tasks
@jviau
Copy link
Contributor Author

jviau commented Jul 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jviau jviau merged commit 57ceed4 into in-proc Aug 1, 2024
@jviau jviau deleted the jviau/in-proc/package-updates branch August 1, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants