Enable log system scope during RPC invocation #10344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
reviewed
Jul 30, 2024
fabiocav
approved these changes
Jul 30, 2024
surgupta-msft
approved these changes
Aug 1, 2024
jviau
added a commit
that referenced
this pull request
Aug 1, 2024
* Enable log system scope during RPC invocation * Add unit test to verify scope * Verify scope reverts to 'User'
kshyju
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Enable log system scope during RPC invocation * Add unit test to verify scope * Verify scope reverts to 'User'
kshyju
added a commit
that referenced
this pull request
Sep 4, 2024
) (#10358) * Enable log system scope during RPC invocation (#10344) * Enable log system scope during RPC invocation * Add unit test to verify scope * Verify scope reverts to 'User' * Remove usage of IHostMetrics type (in test) which does not exist in in-proc branch --------- Co-authored-by: Shyju Krishnankutty <connectshyju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Our RPC function invoker is executed as part of WebJobs function invocation and thus defaults to being 'user' scope. This PR sets it back to system scope within that method so we will resume capturing these logs. This only affects our own logs, does not affect user Application Insights logs.