Skip to content

Log value of FUNCTIONS_EXTENSION_VERSION on host start. Fixes #1835 #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Log value of FUNCTIONS_EXTENSION_VERSION on host start. Fixes #1835 #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/WebJobs.Script/EnvironmentSettingNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ public static class EnvironmentSettingNames
public const string AzureWebJobsSecretStorageType = "AzureWebJobsSecretStorageType";
public const string AppInsightsInstrumentationKey = "APPINSIGHTS_INSTRUMENTATIONKEY";
public const string ProxySiteExtensionEnabledKey = "ROUTING_EXTENSION_VERSION";
public const string FunctionsExtensionVersion = "FUNCTIONS_EXTENSION_VERSION";
}
}
5 changes: 3 additions & 2 deletions src/WebJobs.Script/Host/ScriptHostManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,9 @@ public bool CanInvoke()

OnHostCreated();

string message = string.Format("Starting Host (HostId={0}, Version={1}, ProcessId={2}, Debug={3}, Attempt={4})",
newInstance.ScriptConfig.HostConfig.HostId, ScriptHost.Version, Process.GetCurrentProcess().Id, newInstance.InDebugMode.ToString(), consecutiveErrorCount);
string message = string.Format("Starting Host (HostId={0}, Version={1}, ProcessId={2}, Debug={3}, Attempt={4}, FunctionsExtensionVersion={5})",
newInstance.ScriptConfig.HostConfig.HostId, ScriptHost.Version, Process.GetCurrentProcess().Id, newInstance.InDebugMode.ToString(), consecutiveErrorCount,
_settingsManager.GetSetting(EnvironmentSettingNames.FunctionsExtensionVersion));
_traceWriter?.Info(message);
_logger?.LogInformation(message);

Expand Down
2 changes: 1 addition & 1 deletion test/WebJobs.Script.Tests.Integration/Host/WebScriptHostManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ public Fixture()
"Info Host lock lease acquired by instance ID '(.+)'",
"Info Function 'Excluded' is marked as excluded",
@"Info Generating ([0-9]+) job function\(s\)",
@"Info Starting Host \(HostId=function-tests-node, Version=(.+), ProcessId=[0-9]+, Debug=False, Attempt=0\)",
@"Info Starting Host \(HostId=function-tests-node, Version=(.+), ProcessId=[0-9]+, Debug=False, Attempt=0, FunctionsExtensionVersion=\)",
"Info WebJobs.Indexing Found the following functions:",
"Info The next 5 occurrences of the schedule will be:",
"Info WebJobs.Host Job host started",
Expand Down