Skip to content

Conversation

pragnagopa
Copy link
Member

Set exceptions on language worker process start up errors

@pragnagopa
Copy link
Member Author

@mathewc / @brettsam / @mhoeger - Can you please review. Fixed code paths to fail and log properly if process start up or initialization fails. This is a recent regression as I missed setting exceptions while addressing fixes for race conditions during placeholder mode.

Copy link
Member

@mathewc mathewc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments/questions.

Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but lgtm!

@pragnagopa pragnagopa force-pushed the handleProcessStartErrors branch from 0a41331 to ad448c2 Compare September 5, 2019 22:10
@pragnagopa pragnagopa force-pushed the handleProcessStartErrors branch from 1fab0e7 to 92baa01 Compare September 5, 2019 23:49
@pragnagopa pragnagopa merged commit f47891a into Azure:dev Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants