Adding test for IsRunning logic to return fast #764
Conversation
There was a problem hiding this comment.
nit: rename to SendAsync_HostInErrorState_Returns503Immediately
There was a problem hiding this comment.
How can we verify that the polling loop isn't running in this case? Perhaps add a mock verification below that IsRunning was only called once? To facilitate that test, you should probably add a defaulted ctor param for hostRunningPollIntervalMs so we can configure it to a low value like 50ms for these tests so multiple polls would happen (since we're setting the max timeout to 1 second) if your check isn't working.
There was a problem hiding this comment.
Yes. Currently, this doesn't test the newly introduced behavior and would pass even before the changes were made. We need a test that covers the scenario and passes with the fix in place (i.e. a test that would fail without your change)
There was a problem hiding this comment.
Fixed the PR to address this.
There was a problem hiding this comment.
If you make the suggested change below, we can then update this test to verify that IsRunning is called multiple times, verifying that the polling loop is polling.
There was a problem hiding this comment.
Fixed this in updated commit
|
🚢 |
No description provided.