Skip to content

Conversation

kashimiz
Copy link
Contributor

@kashimiz kashimiz commented Dec 27, 2022

Issue describing the changes in this PR

addresses #8756

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

A couple changes to note:

  • Because this branch removes the appveyor.yaml file, the AppVeyor build will not complete as part of the checks. The build that matters is the one on ADO.
  • The F# SDK is included in Visual Studio 2019, so the manual PATH addition step has been removed.
  • PHP is installed by default on Microsoft-hosted Windows 2019 build agents, so the installation step has been removed.
  • Some tests that passed locally and on AppVeyor failed on the ADO build agent. They were disabled in order to proceed, but issues to investigate and fix them have been created. See tracking issue Re-enable v1 Tests #9003

This PR will be followed by PRs to update the build status badges in branches dev and v3.x:

@liliankasem
Copy link
Member

Definitely a little nervous about disabling the tests but it is for v1 which doesn't get as many changes; would love for the re-enable test issue to be prioritized though

Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echo on Lilian's comment about prioritizing #9003

@kashimiz kashimiz force-pushed the kashimiz/v1adomigration branch from 3c25228 to 1a037d6 Compare January 18, 2023 20:48
@kashimiz kashimiz merged commit 39c9bbd into v1.x Jan 18, 2023
@kashimiz kashimiz deleted the kashimiz/v1adomigration branch January 18, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants