Fix for unhealthy host restart #9851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
With worker indexing enabled all of our worker channels are managed at the webhost level. In such a scenario, if the host becomes unhealthy we restart the script host here
azure-functions-host/src/WebJobs.Script.WebHost/WebJobsScriptHostService.cs
Line 724 in af3687d
However, as part of host restart we do not shutdown the workers started at the webhost level. Once the new host starts up specifically for dotnet-isolated, the request to load the same function is sent again. As the worker has not been restarted it throws an invalidOperation exception with the error.
Result: Failure Exception: System.InvalidOperationException: Unable to load Function '[Function name]'. A function with the id '[Function id]' name already exists
Additional PR information
The fix here was to make sure we shutdown the workers started at the webhost level on host shutdown. Except for when we specialize.
resolves #2124
Pull request checklist
release_notes.md
Additional information
Additional PR information