Skip to content

Conversation

Francisco-Gamino
Copy link
Contributor

Issue describing the changes in this PR

This PR fixes the logic to set $shouldAddSBOM. In my previous PR #919, I updated the logic to set this variable, but failed to consider when $IsReleaseBuild is $null as this assignment [bool]"$(IsReleaseBuild)" will throw in PowerShell. Additionally, I've added some extra logging to see how $shouldAddSBOM is set.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Francisco-Gamino Francisco-Gamino merged commit 4a1bcd5 into dev Mar 14, 2023
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/fix-pipeline branch April 20, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants