Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating templates for recent binding changes #33

Closed
wants to merge 1 commit into from
Closed

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Mar 14, 2016

Absorbing changes from Azure/azure-functions-host@81ee8b7

Also making a few additional cleanups/fixes. E.g., I'm adding some missing samples to the sln file. I added the sln as a way for us to have a project to open to facilitate working on samples. I realize some people use Sublime, but I don't, so keeping this in sync helps me alot. What are others using? Either we keep the sln in sync or remove it - I'm for keeping it :)

@@ -1,5 +1,5 @@
module.exports = function (context, req) {
context.log('Node.js HTTP trigger function processed a request. Name=' + req.originalUrl);
context.log('Node.js HTTP trigger function processed a request. RequestUri=' + req.originalUrl);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for #31

@davidebbo
Copy link

:shipit: But be aware that it goes live as soon as you merge. So if it's dependent on your script changes, let's not merge till those are live.

@@ -7,7 +7,7 @@
},
{
"type": "table",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the json files have an extra level of unecessary indenting. Anyone know why, or whose editor is doing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @soninaren is using VS Code with the default indentation configuration (4 spaces) and that has updated our JSON files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what is everyone else using, 4 spaces? Both my machines are using 2 (VS Enterprise) and I don't recall changing any defaults.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS uses 4 spaces for me for JSON. Not sure what;s the default, but we should all use the same...

@mathewc
Copy link
Member Author

mathewc commented Mar 14, 2016

I'll hold off committing this until we update, since as David says these updates rely on runtime updates.

@soninaren
Copy link
Member

this has been merged in already.

@mathewc mathewc closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants