Storage: regenerate for next link fix #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseeseesee
requested review from
ChenTanyi,
weidongxu-microsoft and
yungezz
as code owners
xseeseesee
commented
Aug 28, 2020
| /** | ||
| * The link to the next page. | ||
| */ | ||
| @JsonProperty("nextLink") |
There was a problem hiding this comment.
@jejner This is new class named PageImpl1 for those have next link in the response.
weidongxu-microsoft
approved these changes
Aug 28, 2020
xseeseesee
commented
Aug 28, 2020
| @@ -836,7 +847,7 @@ public StorageAccountInner call(ServiceResponse<StorageAccountInner> response) { | |||
| @Override | |||
| public Observable<ServiceResponse<Page<StorageAccountInner>>> call(Response<ResponseBody> response) { | |||
| try { | |||
| ServiceResponse<PageImpl<StorageAccountInner>> result = listDelegate(response); | |||
| ServiceResponse<PageImpl1<StorageAccountInner>> result = listDelegate(response); | |||
There was a problem hiding this comment.
Now the operation of listing storage accounts is using PageImpl1. And PageImpl will only work for those don't have next link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1266