Skip to content

Fixed the get method of Rules in AzureFirewallNatRuleCollectionImpl #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fixed the get method of Rules in AzureFirewallNatRuleCollectionImpl #1152

merged 1 commit into from
Oct 19, 2020

Conversation

eitanmechtinger
Copy link
Contributor

Fixed the get method to return the existing rules instead of an empty list

ChenTanyi
ChenTanyi approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@ChenTanyi ChenTanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@weidongxu-microsoft weidongxu-microsoft merged commit 938f476 into Azure:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@xseeseesee xseeseesee Awaiting requested review from xseeseesee

@yungezz yungezz Awaiting requested review from yungezz

+1 more reviewer

@ChenTanyi ChenTanyi ChenTanyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eitanmechtinger @ChenTanyi @weidongxu-microsoft @eitan-mechtinger