-
Notifications
You must be signed in to change notification settings - Fork 4k
Healthcare APIs Powershell BYOK Updates #13518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Updating help files * Updating test recording * Removing unused code in test script
Thank you for your contribution iviark! We will review the pull request and get back to you soon. |
src/HealthcareApis/HealthcareApis/HealthcareApis/NewAzureRmHealthcareApisService.cs
Outdated
Show resolved
Hide resolved
src/HealthcareApis/HealthcareApis/HealthcareApis/NewAzureRmHealthcareApisService.cs
Outdated
Show resolved
Hide resolved
src/HealthcareApis/HealthcareApis/help/New-AzHealthcareApisService.md
Outdated
Show resolved
Hide resolved
src/HealthcareApis/HealthcareApis/help/New-AzHealthcareApisService.md
Outdated
Show resolved
Hide resolved
src/HealthcareApis/HealthcareApis/help/Set-AzHealthcareApisService.md
Outdated
Show resolved
Hide resolved
@@ -19,6 +19,10 @@ | |||
--> | |||
## Upcoming Release | |||
|
|||
## Version 3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about the jump to 3.0.0.
- Changing the first digit indicates a breaking change. But, I don't think this is a breaking change.
- Changing the second digit indicates a non-breaking addition of functionality (ie, a new feature)
The latter seems most appropriate here. In that case, 1.2.0 seems like a good version number. Thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shmartel 3.0.0 is the nuget package version released for Private Link api version: 2020-03-30. Existing versions in the file seems to be the nuget package versions for the respective api version. I referred below link before adding this version in the change log. https://www.nuget.org/packages/Microsoft.Azure.Management.HealthcareApis/
src/HealthcareApis/HealthcareApis/help/New-AzHealthcareApisService.md
Outdated
Show resolved
Hide resolved
@@ -22,6 +22,7 @@ | |||
## Version 3.0.0 | |||
* Updated the SDK version to 3.0.0 | |||
* Added support for Private Link | |||
* Added support for customer managed keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put new item of changelog under upcoming release
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Added support for BYOK for Healthcare Apis
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added