Skip to content

Healthcare APIs Powershell BYOK Updates #13518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 20, 2020
Merged

Healthcare APIs Powershell BYOK Updates #13518

merged 10 commits into from
Nov 20, 2020

Conversation

iviark
Copy link
Contributor

@iviark iviark commented Nov 16, 2020

Description

Added support for BYOK for Healthcare Apis

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Nov 16, 2020
@ghost
Copy link

ghost commented Nov 16, 2020

Thank you for your contribution iviark! We will review the pull request and get back to you soon.

@@ -19,6 +19,10 @@
-->
## Upcoming Release

## Version 3.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about the jump to 3.0.0.

  • Changing the first digit indicates a breaking change. But, I don't think this is a breaking change.
  • Changing the second digit indicates a non-breaking addition of functionality (ie, a new feature)

The latter seems most appropriate here. In that case, 1.2.0 seems like a good version number. Thoughts here?

Copy link
Contributor

@anrudraw anrudraw Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmartel 3.0.0 is the nuget package version released for Private Link api version: 2020-03-30. Existing versions in the file seems to be the nuget package versions for the respective api version. I referred below link before adding this version in the change log. https://www.nuget.org/packages/Microsoft.Azure.Management.HealthcareApis/

@@ -22,6 +22,7 @@
## Version 3.0.0
* Updated the SDK version to 3.0.0
* Added support for Private Link
* Added support for customer managed keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put new item of changelog under upcoming release

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei merged commit af01177 into Azure:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants