Skip to content

Conversation

dagoroz
Copy link
Contributor

@dagoroz dagoroz commented Feb 2, 2021

Reverts #13590

@VeryEarly VeryEarly self-assigned this Feb 3, 2021
@VeryEarly
Copy link
Collaborator

Hi @dagoroz , any particular reason this need to be reverted?

@dingmeng-xue dingmeng-xue changed the base branch from master to release-2021-02-09 February 3, 2021 06:43
@dingmeng-xue
Copy link
Member

LGTM except changelog. I prefer that you just explain the change you did. For instance, removed (past tense is recommended) principal type on New-AzRoleAssignment and Set-AzRoleAssignment because …. (if there is any reason)

@dagoroz
Copy link
Contributor Author

dagoroz commented Feb 3, 2021

@VeryEarly added you to the email thread

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

Hi @dagoroz ,

Due to the Divergence of master branch (base branch of your PR) and release branch, I've created a new PR (from release branch and cherry-picked your commits).
#14122

@VeryEarly VeryEarly closed this Feb 4, 2021
@VeryEarly VeryEarly deleted the revert-13590-passPrincipalType branch August 16, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants